Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use go-git/v5 in bumper instead of calling git binary #12162

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Use go-git/v5 in bumper instead of calling git binary #12162

merged 1 commit into from
Oct 18, 2024

Conversation

KacperMalachowski
Copy link
Contributor

@KacperMalachowski KacperMalachowski commented Oct 17, 2024 •
edited
Loading

Description

Switch from calling git binary to go-git library. That allows us to remove git binary from docker images.

Changes proposed in this pull request:

  • Remove git from image-autobumper docker container's image
  • Rewrite bumper code to use go-git library
  • Remove unused code

Related issue(s)

See: #12056

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 17, 2024
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 17, 2024
@KacperMalachowski KacperMalachowski changed the title Use go-git USe go-git/v5 in bumper instead of calling git binary Oct 18, 2024
@KacperMalachowski KacperMalachowski marked this pull request as ready for review October 18, 2024 02:20
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 18, 2024
@KacperMalachowski KacperMalachowski changed the title USe go-git/v5 in bumper instead of calling git binary Use go-git/v5 in bumper instead of calling git binary Oct 18, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 18, 2024
@kyma-bot kyma-bot merged commit 33e41e8 into kyma-project:main Oct 18, 2024
35 checks passed
@KacperMalachowski KacperMalachowski deleted the fix-image-autobumper branch October 18, 2024 08:01
@dekiel dekiel assigned KacperMalachowski and unassigned akiioto Oct 21, 2024
@KacperMalachowski KacperMalachowski mentioned this pull request Oct 21, 2024
Merged
KacperMalachowski added a commit to KacperMalachowski/test-infra that referenced this pull request Nov 6, 2024
@KacperMalachowski
Use go-git library instead of git binary in bumper (kyma-project#12162)
a4fce7e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akiioto akiioto akiioto approved these changes

@neighbors-dev-bot neighbors-dev-bot Awaiting requested review from neighbors-dev-bot neighbors-dev-bot is a code owner

@Sawthis Sawthis Awaiting requested review from Sawthis Sawthis is a code owner automatically assigned from kyma-project/prow

Assignees

@KacperMalachowski KacperMalachowski

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KacperMalachowski @kyma-bot @akiioto