Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add description of Go internal modules #12336

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Add description of Go internal modules #12336

merged 3 commits into from
Nov 18, 2024

Conversation

KacperMalachowski
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Add description of handling go internal modules in ADO backend.

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 13, 2024
@KacperMalachowski KacperMalachowski marked this pull request as ready for review November 14, 2024 08:50
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 14, 2024
Sawthis
Sawthis requested changes Nov 14, 2024
View reviewed changes
cmd/image-builder/image-builder.md Outdated Show resolved Hide resolved
cmd/image-builder/image-builder.md Outdated Show resolved Hide resolved
@KacperMalachowski @Sawthis
Apply suggestions from code review
0d648b1 
Co-authored-by: Wojciech Sołtys <[email protected]>
@Sawthis Sawthis removed their assignment Nov 15, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 18, 2024
@kyma-bot kyma-bot merged commit e4d5be6 into kyma-project:main Nov 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IwonaLanger IwonaLanger IwonaLanger approved these changes

@Sawthis Sawthis Sawthis approved these changes

@mmitoraj mmitoraj Awaiting requested review from mmitoraj mmitoraj is a code owner

@NHingerl NHingerl Awaiting requested review from NHingerl NHingerl is a code owner

@grego952 grego952 Awaiting requested review from grego952 grego952 is a code owner

@nataliasitko nataliasitko Awaiting requested review from nataliasitko nataliasitko is a code owner

@neighbors-dev-bot neighbors-dev-bot Awaiting requested review from neighbors-dev-bot neighbors-dev-bot is a code owner

Assignees

@KacperMalachowski KacperMalachowski

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KacperMalachowski @Sawthis @IwonaLanger @kyma-bot