Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use semantic versioning for eventing manager #9472

Closed
wants to merge 11 commits into from
Closed

Use semantic versioning for eventing manager #9472

wants to merge 11 commits into from

Conversation

the1bit
Copy link
Contributor

@the1bit the1bit commented Dec 6, 2023

Description

Changes proposed in this pull request:

  • Use semantic versioning for eventing-manager kyma module
  • Use PULL_BASE_REF instead of PULL_BASE_SHA in Tag
  • This solution allows us to test the image building with tag name 0.0.0

Related issue(s)

kyma-project/kyma#18410

@the1bit the1bit added area/eventing Issues or PRs related to eventing kind/feature Categorizes issue or PR as related to a new feature. labels Dec 6, 2023
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 6, 2023
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 6, 2023
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 6, 2023
@the1bit the1bit added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/missing-docs-review Indicates that a PR should not merge beacuse it has missing documentation review. and removed do-not-merge/missing-docs-review Indicates that a PR should not merge beacuse it has missing documentation review. labels Dec 6, 2023
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 6, 2023
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 6, 2023
@kyma-bot
Copy link
Contributor

kyma-bot commented Dec 6, 2023 •
edited
Loading

@the1bit: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-test-infra-validate-generated-files 0821bfc link true /test pre-main-test-infra-validate-generated-files

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@the1bit the1bit closed this Dec 6, 2023
@the1bit the1bit deleted the 18410-Use-semantic-versioning-for-eventing-manager branch December 6, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neighbors-dev-bot neighbors-dev-bot Awaiting requested review from neighbors-dev-bot neighbors-dev-bot is a code owner

@marcobebway marcobebway Awaiting requested review from marcobebway marcobebway was automatically assigned from kyma-project/eventing

Assignees
No one assigned
Labels
area/eventing Issues or PRs related to eventing cla: yes Indicates the PR's author has signed the CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@the1bit @kyma-bot