Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load CountryData from CSV #2

Open
wants to merge 6 commits into
base: development
Choose a base branch
from

Conversation

sammacbeth
Copy link

Instead of pulling data from a MongoDB, use a CSV file with data for all countries, then sub-select the countries to use as agents from this data. This method has the following advantages:

  • Removing a dependency on MongoDB. This is part of the process of allowing other database drivers to be used instead, and to allow simulations to be run without a database set up.
  • The country data is factual and invariant. Therefore rather than having to provide this data again for each simulation it's easier to keep one master data set.
  • The data set is moved into this repository (previously it was hidden in the UI repo). This decreases the coupling of the two repositories and makes it easier to directly invoke simulations rather than having to use the UI.

The attached changeset makes the required changes to load country data from a csv file and uses this file as the data source. There is also some basic unittesting of the new code.

Let me know if these changes seem reasonable.

Sam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant