Migrate to OpenAPI #6
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # tests/ClientTest.php # tests/Endpoint/CategoryEndpointTest.php # tests/Factory/CategoryFactoryTest.php # tests/Factory/TokenFactoryTest.php
|
As far as I remember this branch contains valid (working) changes, but there were some confusion from us, about how Open API implemented on Alibaba side. I think tokens had too short TTL, maybe some other issues with authorisation as well 🤔 That's why this was never merged, as required some clarifications with Alibaba. But, this was some time ago, maybe I remember it wrong. Also could be that Alibaba changed implementation during this time. Please double check before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just came across this branch. I don't know what its status is and if @vstelmakh was actually going to create a PR for it, but at least to me the work looks relevant and promising, and could be an approach to solve auth issues in current
master.