Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Fixed cookie_mask query to match a range of cookies #130

Merged
merged 2 commits into from
Jan 23, 2023

Conversation

viniarck
Copy link
Member

Closes #129

Summary

Also, to recap, FYI, flow_manager still doesn't validate completely the payload on this endpoint, so invalid type or values can lead to issues, but that will be covered on issue #43

End-to-End Tests

I've added three new e2e tests to cover the ranges with cookie_mask on another PR kytos-ng/kytos-end-to-end-tests#197, to also cover the original issue that Italo has caught, and ran flow_manager related tests again:

+ python3 -m pytest tests/ --timeout=600 -k flow_manager
============================= test session starts ==============================
platform linux -- Python 3.9.2, pytest-7.2.0, pluggy-1.0.0
rootdir: /tests
plugins: rerunfailures-10.2, timeout-2.1.0
timeout: 600.0s
timeout method: signal
timeout func_only: False
collected 204 items / 154 deselected / 50 selected

tests/test_e2e_20_flow_manager.py ..................                     [ 36%]
tests/test_e2e_21_flow_manager.py ..                                     [ 40%]
tests/test_e2e_22_flow_manager.py ...............                        [ 71%]
tests/test_e2e_23_flow_manager.py ...............                        [100%]

------------------------------- start/stop times -------------------------------
======== 50 passed, 154 deselected, 137 warnings in 2625.36s (0:43:45) =========

I've also dispatched the entire e2e test suite for complenetess, I'll post the results with this branch later.

I'll be back on Jan 31.

@viniarck viniarck requested a review from a team January 21, 2023 17:59
@viniarck
Copy link
Member Author

e2e test suites passed with e2e branch test/cookie_mask_range and flow_manager branch fix/delete_cookie_mask:

+ python3 -m pytest tests/ --reruns 2 -r fEr
============================= test session starts ==============================
platform linux -- Python 3.9.2, pytest-7.2.0, pluggy-1.0.0
rootdir: /builds/amlight/kytos-end-to-end-tester/kytos-end-to-end-tests
plugins: rerunfailures-10.2, timeout-2.1.0
collected 204 items
tests/test_e2e_01_kytos_startup.py ..                                    [  0%]
tests/test_e2e_05_topology.py ..................                         [  9%]
tests/test_e2e_10_mef_eline.py ..........ss.....x.....x.....             [ 24%]
tests/test_e2e_11_mef_eline.py .....                                     [ 26%]
tests/test_e2e_12_mef_eline.py .....xx.                                  [ 30%]
tests/test_e2e_13_mef_eline.py .....xxXx......xxXx.XXxX.xxxx..x......... [ 50%]
...                                                                      [ 51%]
tests/test_e2e_14_mef_eline.py x                                         [ 52%]
tests/test_e2e_15_mef_eline.py .                                         [ 52%]
tests/test_e2e_20_flow_manager.py ...................                    [ 62%]
tests/test_e2e_21_flow_manager.py ..                                     [ 63%]
tests/test_e2e_22_flow_manager.py ...............                        [ 70%]
tests/test_e2e_23_flow_manager.py ..............                         [ 77%]
tests/test_e2e_30_of_lldp.py ....                                        [ 79%]
tests/test_e2e_31_of_lldp.py ...                                         [ 80%]
tests/test_e2e_32_of_lldp.py ...                                         [ 82%]
tests/test_e2e_40_sdntrace.py ....                                       [ 84%]
tests/test_e2e_41_kytos_auth.py ........                                 [ 88%]
tests/test_e2e_50_maintenance.py ........................                [100%]
=============================== warnings summary ===============================
------------------------------- start/stop times -------------------------------
= 180 passed, 2 skipped, 17 xfailed, 5 xpassed, 793 warnings in 10552.74s (2:55:52) =

Copy link

@italovalcy italovalcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for push commits to fix this issue and for also adding tests (unit and e2e)!

@italovalcy italovalcy merged commit 9e2cc89 into master Jan 23, 2023
@italovalcy italovalcy deleted the fix/delete_cookie_mask branch January 23, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete flows by cookie and cookie_mask is not working
2 participants