Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip certain xfail tests that are causing tracebacks for now #227

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

viniarck
Copy link
Member

@viniarck viniarck commented Apr 10, 2023

Closes #224

Summary

  • Skipped certain xfail tests that are causing tracebacks for now, which are just false positive noise in the logs. Once validations are in place then this will be reverted (I'll map another issue shortly for this)

Local Tests

I made sure that of the tests was properly skipped

Ran 'hello' command on MongoDB successfully. It's ready!
+ python3 -m pytest tests/ -k test_035_patch_an_inconsistent_uni_a
============================= test session starts ==============================
platform linux -- Python 3.9.2, pytest-6.2.5, py-1.11.0, pluggy-1.0.0
rootdir: /tests
plugins: timeout-2.0.2
collected 227 items / 226 deselected / 1 selected

tests/test_e2e_13_mef_eline.py s                                         [100%]

=============================== warnings summary ===============================
usr/local/lib/python3.9/dist-packages/kytos/core/config.py:186
  /usr/local/lib/python3.9/dist-packages/kytos/core/config.py:186: UserWarning: Unknown arguments: ['tests/', '-k', 'test_035_patch_an_inconsistent_uni_a']
    warnings.warn(f"Unknown arguments: {unknown}")

-- Docs: https://docs.pytest.org/en/stable/warnings.html
------------------------------- start/stop times -------------------------------
================ 1 skipped, 226 deselected, 1 warning in 0.64s =================

End-to-End Tests

Not necessary to rerun the entire test suite since it's just skipping and there's no syntax errors

@viniarck
Copy link
Member Author

Appreciated your review @gretelliz

@viniarck viniarck merged commit 8d0b671 into master Apr 10, 2023
@viniarck viniarck deleted the test/skip branch April 10, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pytest.mark.skip instead of xfail to avoid tracebacks on validations that aren't in place yet
2 participants