Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Augmented blueprint EP031 telemetry_int #402

Merged
merged 15 commits into from
Oct 10, 2023
Merged

Conversation

viniarck
Copy link
Member

Closes #400

Summary

As I was breaking down the epic_telemetry_int_v1 epic, I realized that certain minor requirements still needed further refinement or confirmation, so I went ahead and augmented here accordingly. Also, I updated the rest endpoints accordingly based on the initial prototype that @jab1982 has developed. cc'ing @jab1982 and @italovalcy to confirm and discuss if the requirements are as expected for this v1 iteration.

@viniarck viniarck requested a review from a team as a code owner July 26, 2023 20:16
docs/blueprints/EP031.rst Outdated Show resolved Hide resolved
docs/blueprints/EP031.rst Outdated Show resolved Hide resolved
docs/blueprints/EP031.rst Outdated Show resolved Hide resolved
Copy link

@italovalcy italovalcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent points, Vinicius! thanks for sending the updates. I've made a few comments, please let me know if they make any sense for you.

docs/blueprints/EP031.rst Outdated Show resolved Hide resolved
docs/blueprints/EP031.rst Show resolved Hide resolved
docs/blueprints/EP031.rst Show resolved Hide resolved
docs/blueprints/EP031.rst Show resolved Hide resolved
docs/blueprints/EP031.rst Show resolved Hide resolved
docs/blueprints/EP031.rst Outdated Show resolved Hide resolved
docs/blueprints/EP031.rst Outdated Show resolved Hide resolved
docs/blueprints/EP031.rst Outdated Show resolved Hide resolved
@viniarck viniarck requested a review from gretelliz July 27, 2023 20:57
docs/blueprints/EP031.rst Outdated Show resolved Hide resolved
docs/blueprints/EP031.rst Outdated Show resolved Hide resolved
@viniarck
Copy link
Member Author

viniarck commented Oct 6, 2023

@jab1982 and @italovalcy thanks for your inputs regarding the requirements meeting. I've pushed three new commits a699943, c2330dc, 2096fc5 updating the text based on the decisions on yesterday's meeting. In case you want to re-review again this PR will stay open for a few days before getting merged.

@viniarck viniarck merged commit 0aea4b7 into master Oct 10, 2023
2 checks passed
@viniarck viniarck deleted the blueprint/ep031_part2 branch October 10, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

placeholder to augment blueprint EP031 (telemetry_int)
2 participants