Pacing additions #483
Merged
Pacing additions #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds additional tools to pacing, that weren't originally considered.
So far, this adds:
ignore_pacestrategy, which ignores the pace, and always lets the action execute.is_configuredfor checking if the pace for a given action has beenOne potential inclusion to this PR is logging when the limit is reached. The reason it hasn't been included yet, is that this can quickly end up filling the log, when many actions with the same keys are queued.
Local Tests
Everything seem to be working well here.
End-to-End Tests
Haven't conducted yet.