Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactors log message Limited reached: to Limit reached: #499

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

Ktmi
Copy link

@Ktmi Ktmi commented Sep 9, 2024

Closes #498

Summary

Refactors a logging grammar mistake.

Local Tests

Seems to still work the same.

End-to-End Tests

(Probably) Not necessary.

@Ktmi Ktmi requested a review from a team as a code owner September 9, 2024 19:03
Copy link
Member

@viniarck viniarck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Are you going to retag 2024.1.1? Otherwise this needs to be bumped as 2024.1.2. It's up to you especially since this is just a quick/trivial fix retagging should be easier though.

@Ktmi
Copy link
Author

Ktmi commented Sep 10, 2024

@viniarck I'll try to retag.

@Ktmi Ktmi merged commit 9241579 into master Sep 10, 2024
2 checks passed
@Ktmi Ktmi deleted the chore/pacing_log_message branch September 10, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: refactor log.info "Limited reached" as "Limit reached"
2 participants