Replies: 1 comment
-
Reviewing
What if we handle these cases in three different consistency checks:
Some enhancements to
These are wild ideas discard them all if you see best. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
There are a few processes we would like to rework in regards to consistency check:
EVCs modified without holding lock, may lead to race conditions #512 - Protect EVCs during the consistency check process. It's possible that an EVC may be modified during consistency check, as the EVC lock isn't maintained throughout the process.
Replace consistency check with routine for checking traces #437 - Perform traces on all deployed (active) EVCs. Currently traces are only performed on inactive EVCs to check if they are deployed, in order to set them to active. However with the current implementation of
mef_eline
, all deployed EVCs are set as active, and maintain the active state between restarts.consistency: redeploy EVCs that are enabled and inactive and now have paths to be deployed #395 - Periodically try to deploy EVCs that are inactive. There could be cases where a path is available for an EVC, but the EVC wasn't deployed due to some unexpected factor.
Consistency check: remove orphan flows from an EVC #444 - Clearing orphan flows. EVCs may not have properly deleted flows from a previous path.
Optimize consistency check routine to avoid trying to activate EVCs unnecessarily #247 - Prevent EVCs from trying to redeploy too often. This is mainly a constraint on trying to deploy inactive EVCs.
Of these issues, the main problematic one I'm seeing is #444. Identifying orphan flows is a non trivial issue, being that we must identify flows pertaining to the EVC, that we might not know if they exist, or where they may exist.
Beta Was this translation helpful? Give feedback.
All reactions