Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link maintenance should reflect on the service being deactivated if no alternative path is found #519

Open
italovalcy opened this issue Oct 2, 2024 · 3 comments

Comments

@italovalcy
Copy link

According to the Maintenance blueprint, when a Link is under maintenance and the impacted EVC has no alternative path, the service should be deactivated. This should be done not only from the control plane perspective, but also on the dataplane perspective. Meaning: we should remove the flows from that particular EVC once the MW starts if no alternative path is found for that particular EVC.

It seems that only the control plane part is being done now.

Cc'ing @RenataFrez and @jab1982 so they can also share their perspective as network operators.

@RenataFrez
Copy link

I have the same opinion as Italo. From the operations perspective, I see two significant issues with the current approach:

  1. If the dataplane continues forwarding the traffic through a link in maintenance mode, we lose the primary goal of this mode: avoid unexpected impact to the users. For example, we generally use Maintenance Mode when a link is degraded (flapping, losing packets) or when a planned activity is scheduled. In both scenarios, we want to minimize the user impact by removing the cause of the instability. If some EVCs remain in the affected link, the users see their routing tables being recalculated, which could affect their traffic. In this case, it's better to have a link down than to switch traffic from one side to another.
  2. For the operator, seeing an EVC as Active = False but having the Dataplane still working could lead to wrong assumptions when troubleshooting an issue.

@jab1982
Copy link

jab1982 commented Oct 2, 2024

If the data plane configuration is removed, when it is time to end the maintenance, we will have no ways of testing the link to make sure it is error-free and ready for production. That was one of the reasons the process is the way it is today.

@jab1982
Copy link

jab1982 commented Oct 2, 2024

Maybe a new metadata might be created to help. If metadata "never_disable" is on, the EVC should never be removed. Then we use those for testing, for instance, with BERToD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants