Improve dependency management output #140
Conversation
There was a problem hiding this comment.
@macartur I think that we need to do some logic changes regarding napp installation and activation.
IMHO the napp dependencies must be installed prior to the installation of the napp itself. If the installation of any dependency fails, then the process must be stopped [the best scenario would be to get the system back to the point it was before the installation was called, but lets not worry about it now].
The same goes for 'enabling' a NApp. Before enabling a NApp we need to successfully enable its requirements. Always.
|
@diraol, you are right. We could open another issue with what you said. I opened this one just to make the output less confusing, without changing functionality. |
There was a problem hiding this comment.
Only some indentation is not as requested. The idea is two have 2 columns: 1 for level (INFO, WARNING, ERROR) and the second for the message. The indentation is 2 spaces.
Particularly, the lines above "Installing Dependencies:" are not indented in a level below and the warning message indentation is more than 2 spaces away from the above message.
kytos/cli/commands/napps/api.py
Outdated
| LOG.info('Installing Dependencies:') | ||
| cls.install_napps(napp_dependencies) | ||
| else: | ||
| LOG.warning(' Napp already Enabled.') |
There was a problem hiding this comment.
"NApp already installed and enabled." would be a bit better.
Fix #135