Bumping up eslint to latest and changing Linter to CLIEngine

### REASON
solve several eslint issues (es-analysis#166, es-analysis#211)

lib/cli.js

@@ -30,7 +30,8 @@ exports.exec = function(options, done) {
     q: !!exports.args.q,
     title : exports.args.t && exports.args.t.value,
     exclude : exports.args.x && new RegExp(exports.args.x.value),
-    date : exports.args.D && exports.args.D.value
+    date : exports.args.D && exports.args.D.value,
+    eslint: exports.args.e && exports.args.e.value
   };
   var json;
   var jshintrc = {};
@@ -43,11 +44,6 @@ exports.exec = function(options, done) {
     platoOptions.jshint = { globals : jshintrc.globals || {} };
     delete jshintrc.globals;
     platoOptions.jshint.options = jshintrc;
-
-  } else if (exports.args.e) {
-    json = fs.readFileSync(exports.args.e.value).toString();
-    jshintrc = JSON.parse(util.stripComments(json));
-    platoOptions.eslint = jshintrc;
   }
 
   plato.inspect(files, outputDir, platoOptions, done);

lib/plato.js

@@ -61,11 +61,25 @@ exports.inspect = function(files, outputDir, options, done) {
     jshint : {} // use jshint defaults
   };
 
+  // TODO: separate jshint and eslint on running `runReports`
   if (options.eslint) {
-    options.jshint = options.eslint;
-    reporters.jshint = reporters.eslint;
+    if (typeof options.eslint === "string") {
+      options.jshint = {
+        configFile: path.resolve(options.eslint)
+      };
+    } else {
+      options.eslint.baseConfig = options.eslint.baseConfig || {};
+      ["extends", "overrides", "settings"].forEach(function(configKey){
+        if (options.eslint[configKey]) {
+          options.eslint.baseConfig[configKey] = options.eslint[configKey];
+          delete options.eslint[configKey];
+        }
+      });
+      options.jshint = options.eslint;
+    }
     delete options.eslint;
-    delete reporters.eslint;
+    reporters.jshint = reporters.eslint;
+    // delete reporters.eslint; // NOTE: don't delete because can't reuse `inspect`
   }
 
   Object.keys(flags).forEach(function(flag){

lib/reporters/eslint/index.js

@@ -1,6 +1,8 @@
 "use strict";
 
-var ESLINT = require("eslint");
+// @see http://www.phpied.com/using-eslint-in-a-script/
+// @see https://eslint.org/docs/developer-guide/nodejs-api#cliengine
+var CLIEngine = require("eslint").CLIEngine;
 
 exports.process = function (source, options/*, reportInfo */) {
   var results = lint(source, options);
@@ -36,7 +38,8 @@ function lint(source, config) {
   // Remove potential Unicode BOM.
   source = source.replace(/^\uFEFF/, "");
 
-  var messages = ESLINT.linter.verify(source, config);
+  var cli = new CLIEngine(config);
+  var messages = cli.executeOnText(source).results[0].messages;
   results = results.concat(messages);
 
   return {

package.json

@@ -47,7 +47,7 @@
     "analyze"
   ],
   "dependencies": {
-    "eslint": "~3.0.1",
+    "eslint": "6.0.1",
     "fs-extra": "~0.30.0",
     "glob": "~7.0.5",
     "jshint": "~2.9.2",

test/fixtures/.eslintrc.json

@@ -0,0 +1,24 @@
+{
+  "rules": {
+    "indent": [
+      2,
+      4
+    ],
+    "quotes": [
+      2,
+      "single"
+    ],
+    "linebreak-style": [
+      2
+    ],
+    "semi": [
+      2,
+      "always"
+    ],
+    "no-console": 0
+  },
+  "env": {
+    "node": true
+  },
+  "extends": "eslint:recommended"
+}

test/plato_test.js

@@ -141,5 +141,43 @@ exports['plato'] = {
       test.ok(overview.summary.total.jshint === 4, 'Should contain total jshint issues');
       test.done();
     });
+  },
+
+  'should run eslint with config file' : function(test) {
+    // #166 test-case
+    var options = {
+      eslint: 'test/fixtures/.eslintrc.json'
+    };
+    var files = [
+      'test/fixtures/a.js',
+      'test/fixtures/b.js'
+    ];
+
+    test.expect(1);
+
+    plato.inspect(files, null, options, function(reports) {
+      var overview = plato.getOverviewReport(reports);
+      test.ok(overview.summary.total.jshint === 8, 'Should contain total eslint issues');
+      test.done();
+    });
+  },
+
+  'should run eslint with config object' : function(test) {
+    // #211 test-case
+    var options = {
+      eslint: require('./fixtures/.eslintrc.json')
+    };
+    var files = [
+      'test/fixtures/a.js',
+      'test/fixtures/b.js'
+    ];
+
+    test.expect(1);
+
+    plato.inspect(files, null, options, function(reports) {
+      var overview = plato.getOverviewReport(reports);
+      test.ok(overview.summary.total.jshint === 8, 'Should contain total eslint issues');
+      test.done();
+    });
   }
 };