Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better #18

Closed
wants to merge 2 commits into from
Closed

Better #18

wants to merge 2 commits into from

Conversation

adefossez
Copy link
Collaborator

No description provided.

@@ -193,6 +200,8 @@ async def main():
state = ServerState()
log("info", "warming up the model")
state.warmup()
tunnel = networking.setup_tunnel('127.0.0.1', args.port, 'testlapin', None)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we would want to make this the default, though I like testlapin. Maybe put it behind a command line flag?

@LaurentMazare
Copy link
Member

I've also made some changes in sphn that should ensure that we only send complete ogg frames (available in sphn==0.1.4), see kyutai-labs/sphn#4 It seems to also get rid of the issue but having both fixes sounds reasonable.

@adefossez adefossez closed this Sep 17, 2024
@adefossez adefossez deleted the better branch September 18, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants