Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix secretRef and handle invalid target config #817

Merged
merged 1 commit into from
Mar 11, 2025
Merged

fix secretRef and handle invalid target config #817

merged 1 commit into from
Mar 11, 2025

Conversation

fjogeleit
Copy link
Member

No description provided.

@fjogeleit fjogeleit enabled auto-merge (squash) March 11, 2025 09:43
@fjogeleit fjogeleit merged commit 86f8d25 into main Mar 11, 2025
5 checks passed
@fjogeleit fjogeleit deleted the crd-fixes branch March 11, 2025 09:45
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13784896372

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 13 of 29 (44.83%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 81.706%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/targetconfig/client.go 3 9 33.33%
pkg/target/factory/factory.go 5 15 33.33%
Totals Coverage Status
Change from base Build 13776031249: 0.1%
Covered Lines: 6601
Relevant Lines: 8079

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants