Skip to content

Commit

Permalink
fix: reports-server restart in default installation (#152)
Browse files Browse the repository at this point in the history
Signed-off-by: Vishal Choudhary <[email protected]>
  • Loading branch information
vishal-chdhry authored Jul 4, 2024
1 parent 8164f93 commit 2f1e5d8
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 7 deletions.
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ REGISTER_GEN := $(TOOLS_DIR)/register-gen
OPENAPI_GEN := $(TOOLS_DIR)/openapi-gen
CODE_GEN_VERSION := v0.28.0
KIND := $(TOOLS_DIR)/kind
KIND_VERSION := v0.20.0
KIND_VERSION := v0.23.0
KO := $(TOOLS_DIR)/ko
KO_VERSION := v0.14.1
HELM := $(TOOLS_DIR)/helm
Expand Down Expand Up @@ -192,7 +192,7 @@ verify-codegen: codegen ## Verify all generated code and docs are up to date
# KIND #
########

KIND_IMAGE ?= kindest/node:v1.28.0
KIND_IMAGE ?= kindest/node:v1.30.0
KIND_NAME ?= kind

.PHONY: kind-create
Expand Down
4 changes: 2 additions & 2 deletions charts/reports-server/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ helm install reports-server --namespace reports-server --create-namespace report
| podAnnotations | object | `{}` | Pod annotations |
| podSecurityContext | object | `{"fsGroup":2000}` | Pod security context |
| securityContext | object | See [values.yaml](values.yaml) | Container security context |
| livenessProbe | object | `{"failureThreshold":3,"httpGet":{"path":"/livez","port":"https","scheme":"HTTPS"},"periodSeconds":10}` | Liveness probe |
| readinessProbe | object | `{"failureThreshold":3,"httpGet":{"path":"/readyz","port":"https","scheme":"HTTPS"},"initialDelaySeconds":20,"periodSeconds":10}` | Readiness probe |
| livenessProbe | object | `{"failureThreshold":3,"httpGet":{"path":"/livez","port":"https","scheme":"HTTPS"},"initialDelaySeconds":90,"periodSeconds":10}` | Liveness probe |
| readinessProbe | object | `{"failureThreshold":3,"httpGet":{"path":"/readyz","port":"https","scheme":"HTTPS"},"initialDelaySeconds":100,"periodSeconds":10}` | Readiness probe |
| resources.limits | string | `nil` | Container resource limits |
| resources.requests | string | `nil` | Container resource requests |
| autoscaling.enabled | bool | `false` | Enable autoscaling |
Expand Down
3 changes: 2 additions & 1 deletion charts/reports-server/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ securityContext:
# -- Liveness probe
livenessProbe:
failureThreshold: 3
initialDelaySeconds: 90
periodSeconds: 10
httpGet:
path: /livez
Expand All @@ -89,7 +90,7 @@ livenessProbe:

# -- Readiness probe
readinessProbe:
initialDelaySeconds: 20
initialDelaySeconds: 100
failureThreshold: 3
periodSeconds: 10
httpGet:
Expand Down
3 changes: 2 additions & 1 deletion config/install-inmemory.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -198,14 +198,15 @@ spec:
path: /livez
port: https
scheme: HTTPS
initialDelaySeconds: 90
periodSeconds: 10
readinessProbe:
failureThreshold: 3
httpGet:
path: /readyz
port: https
scheme: HTTPS
initialDelaySeconds: 20
initialDelaySeconds: 100
periodSeconds: 10
resources:
limits: null
Expand Down
3 changes: 2 additions & 1 deletion config/install.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -293,14 +293,15 @@ spec:
path: /livez
port: https
scheme: HTTPS
initialDelaySeconds: 90
periodSeconds: 10
readinessProbe:
failureThreshold: 3
httpGet:
path: /readyz
port: https
scheme: HTTPS
initialDelaySeconds: 20
initialDelaySeconds: 100
periodSeconds: 10
resources:
limits: null
Expand Down

0 comments on commit 2f1e5d8

Please sign in to comment.