fix(charts): remove erroneous 'metadata' key from ClusterRole object #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikedougherty
force-pushed
the
fixup-clusterrole-extra-metadata
branch
from
cd5c16c
to
68e8246
Compare
Signed-off-by: Mike Dougherty <[email protected]>
mikedougherty
force-pushed
the
fixup-clusterrole-extra-metadata
branch
from
68e8246
to
d2dbbfb
Compare
JimBugwadia
approved these changes
Jun 14, 2024
stone-z
pushed a commit
to giantswarm/reports-server-upstream
that referenced
this pull request
Jul 4, 2024
…yverno#119) Signed-off-by: Mike Dougherty <[email protected]> Co-authored-by: Jim Bugwadia <[email protected]> Signed-off-by: Zach Stone <[email protected]>
stone-z
pushed a commit
to giantswarm/reports-server-upstream
that referenced
this pull request
Jul 4, 2024
…yverno#119) Signed-off-by: Mike Dougherty <[email protected]> Co-authored-by: Jim Bugwadia <[email protected]> Signed-off-by: Zach Stone <[email protected]>
stone-z
pushed a commit
to giantswarm/reports-server-upstream
that referenced
this pull request
Jul 9, 2024
…yverno#119) Signed-off-by: Mike Dougherty <[email protected]> Co-authored-by: Jim Bugwadia <[email protected]> Signed-off-by: Zach Stone <[email protected]>
vishal-chdhry
pushed a commit
that referenced
this pull request
Jul 10, 2024
* Create sync-from-upstream.yaml Signed-off-by: Zach Stone <[email protected]> * Update sync-from-upstream.yaml Signed-off-by: Zach Stone <[email protected]> * fix(charts): remove erroneous 'metadata' key from ClusterRole object (#119) Signed-off-by: Mike Dougherty <[email protected]> Co-authored-by: Jim Bugwadia <[email protected]> Signed-off-by: Zach Stone <[email protected]> * Enable metrics endpoint and add service monitor Signed-off-by: Zach Stone <[email protected]> * Update generated install Signed-off-by: Zach Stone <[email protected]> * Do not enable ServiceMonitor by default Signed-off-by: Zach Stone <[email protected]> * Rerun codegen Signed-off-by: Zach Stone <[email protected]> --------- Signed-off-by: Zach Stone <[email protected]> Signed-off-by: Mike Dougherty <[email protected]> Co-authored-by: Mike Dougherty <[email protected]> Co-authored-by: Jim Bugwadia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an extra 'metadata' key in this object.
Previously when building the chart wrapped by kustomize-v5.4.1 using the helmCharts generator, this error would occur:
With this change, the chart is buildable and kustomize does not report an error:
Hopefully this is straightforward, please let me know if there is any other info I can provide.
My team and I are looking forward to trying out this component, cheers!