Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to configure volumes through values.yaml #217

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions charts/reports-server/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,8 @@ helm install reports-server --namespace reports-server --create-namespace report
| apiServicesManagement.podAnnotations | object | `{}` | Pod annotations. |
| apiServicesManagement.nodeAffinity | object | `{}` | Node affinity constraints. |
| apiServicesManagement.securityContext | object | `{"allowPrivilegeEscalation":false,"capabilities":{"drop":["ALL"]},"privileged":false,"readOnlyRootFilesystem":true,"runAsGroup":65534,"runAsNonRoot":true,"runAsUser":65534,"seccompProfile":{"type":"RuntimeDefault"}}` | Security context for the hook containers |
| extraVolumes.volumeMounts | list | `[]` | Extra volume mounts for reports-server container |
| extraVolumes.volumes | list | `[]` | Extra volumes for reports-server deployment |

## Source Code

Expand Down
6 changes: 6 additions & 0 deletions charts/reports-server/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,9 @@ spec:
volumeMounts:
- mountPath: /tmp
name: tmp-dir
{{- with .Values.extraVolumes.volumeMounts }}
{{ toYaml . | nindent 12 | trim }}
{{- end }}
{{- with .Values.livenessProbe }}
livenessProbe:
{{- toYaml . | nindent 12 }}
Expand All @@ -119,3 +122,6 @@ spec:
volumes:
- emptyDir: {}
name: tmp-dir
{{- with .Values.extraVolumes.volumes }}
{{ toYaml . | nindent 6 | trim }}
{{- end }}
4 changes: 4 additions & 0 deletions charts/reports-server/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -273,3 +273,7 @@ apiServicesManagement:
- ALL
seccompProfile:
type: RuntimeDefault

extraVolumes:
volumeMounts: []
volumes: []
Loading