Skip to content

TabsListManager refactor to have use cases #57

TabsListManager refactor to have use cases

TabsListManager refactor to have use cases #57

Triggered via pull request February 4, 2024 11:42
Status Failure
Total duration 40s
Artifacts

swift.yml

on: pull_request
lint-ios
30s
lint-ios
lint-kotlin-cotton-base
14s
lint-kotlin-cotton-base
ios-unit-tests
0s
ios-unit-tests
build-ios
0s
build-ios
Fit to window
Zoom out
Zoom in

Annotations

8 errors and 12 warnings
lint-ios: catowseriOS/CottonDataTests/WebViewVM/WebViewVmDNSoverHTTPSConcurrencyTests.swift#L35
Force Unwrapping Violation: Force unwrapping should be avoided (force_unwrapping)
lint-ios: catowseriOS/catowser/Coordinators/SearchBarCoordinator.swift#L122
Unneeded Break in Switch Violation: Avoid using unneeded break statements (unneeded_break_in_switch)
lint-ios: catowseriOS/catowser/Coordinators/SearchBarCoordinator.swift#L143
Unneeded Break in Switch Violation: Avoid using unneeded break statements (unneeded_break_in_switch)
lint-ios: catowseriOS/catowser/Environment/UseCaseFactory.swift#L42
Force Unwrapping Violation: Force unwrapping should be avoided (force_unwrapping)
lint-ios: catowseriOS/CottonData/WebViewModel/WebViewModelState.swift#L51
Force Try Violation: Force tries should be avoided (force_try)
lint-ios: catowseriOS/CottonData/WebViewModel/WebViewModelState.swift#L86
Force Unwrapping Violation: Force unwrapping should be avoided (force_unwrapping)
lint-ios: catowseriOS/CottonData/WebViewModel/WebViewModelState.swift#L185
Force Unwrapping Violation: Force unwrapping should be avoided (force_unwrapping)
lint-ios: catowseriOS/CottonData/WebViewModel/WebViewModelState.swift#L185
Force Unwrapping Violation: Force unwrapping should be avoided (force_unwrapping)
lint-kotlin-cotton-base
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
lint-ios
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
lint-ios: catowseriOS/ReactiveHttpKit/URL+Rx.swift#L18
Control Statement Violation: `if`, `for`, `guard`, `switch`, `while`, and `catch` statements shouldn't unnecessarily wrap their conditionals or arguments in parentheses (control_statement)
lint-ios: catowseriOS/CssParser/Scanner.swift#L404
No Fallthrough only Violation: Fallthroughs can only be used if the `case` contains at least one other statement (no_fallthrough_only)
lint-ios: catowseriOS/CottonPlugins/Models/CSSModels/CSSBackgroundImage.swift#L42
Orphaned Doc Comment Violation: A doc comment should be attached to a declaration (orphaned_doc_comment)
lint-ios: catowseriOS/CottonRestKit/RestClientError.swift#L60
Superfluous Disable Command Violation: SwiftLint rule 'function_body_length' did not trigger a violation in the disabled region; remove the disable command (superfluous_disable_command)
lint-ios: catowseriOS/CottonRestKit/Extensions/URL+Extensions.swift#L52
Control Statement Violation: `if`, `for`, `guard`, `switch`, `while`, and `catch` statements shouldn't unnecessarily wrap their conditionals or arguments in parentheses (control_statement)
lint-ios: catowseriOS/CottonRestKit/Extensions/URL+Extensions.swift#L62
Control Statement Violation: `if`, `for`, `guard`, `switch`, `while`, and `catch` statements shouldn't unnecessarily wrap their conditionals or arguments in parentheses (control_statement)
lint-ios: catowseriOS/CottonRestKit/ResponseHandlingApiType.swift#L25
Orphaned Doc Comment Violation: A doc comment should be attached to a declaration (orphaned_doc_comment)
lint-ios: catowseriOS/CottonRestKit/ResponseHandlingApiType.swift#L70
Todo Violation: TODOs should be resolved (could use UUID for each `Respo...) (todo)
lint-ios: catowseriOS/CottonRestKit/HTTPAdapter.swift#L21
Orphaned Doc Comment Violation: A doc comment should be attached to a declaration (orphaned_doc_comment)
lint-ios: catowseriOS/CottonRestKit/ClientSubscriber.swift#L28
Orphaned Doc Comment Violation: A doc comment should be attached to a declaration (orphaned_doc_comment)