Fix Xcode 15 build #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atest Android Studio Giraffe uses 1.9. Fix OptIn annotations for new Kotlin version.
…latest SDK because local version is different on different Apple devices
…ch/Cotton into bug/xcode_15_and_kotlin_1_9_build
… ktlint and it also ignores yml config file, so, it is not possible to ignore some lint errors
kyzmitch
added a commit
that referenced
this pull request
Mar 13, 2024
* Update Kotlin to 1.9.0 in Multiplatform cotton-base project because latest Android Studio Giraffe uses 1.9. Fix OptIn annotations for new Kotlin version. * Fix Xcode 15 and add build for Apple Silicon macos for the unit tests * Fix Xcpretty calls, fix macOS sdk for local make command to just use latest SDK because local version is different on different Apple devices * Attempt to fix linking * mocks gen fix * Update kotlin plugin for Xcode 15 * Add not related swift 5.9 feature for AsyncStream type * Move some files to different build target where they belong * Fix build on Apple silicon * Attempt to select Xcode version on the runner * Android gradle plugin fix, 7.4.0 is the maximum version supported by IntelliJ IDEA * JDK 17 * Use corretto-17 jdk * Implement top site selection * State hoisting? * Store vm on the upper level * Fix kotlin lint errors * Disable ktlint github action because it conflicts too much with local ktlint and it also ignores yml config file, so, it is not possible to ignore some lint errors * Remove android linter step completely
kyzmitch
added a commit
that referenced
this pull request
Mar 13, 2024
* Update Kotlin to 1.9.0 in Multiplatform cotton-base project because latest Android Studio Giraffe uses 1.9. Fix OptIn annotations for new Kotlin version. * Fix Xcode 15 and add build for Apple Silicon macos for the unit tests * Fix Xcpretty calls, fix macOS sdk for local make command to just use latest SDK because local version is different on different Apple devices * Attempt to fix linking * mocks gen fix * Update kotlin plugin for Xcode 15 * Add not related swift 5.9 feature for AsyncStream type * Move some files to different build target where they belong * Fix build on Apple silicon * Attempt to select Xcode version on the runner * Android gradle plugin fix, 7.4.0 is the maximum version supported by IntelliJ IDEA * JDK 17 * Use corretto-17 jdk * Implement top site selection * State hoisting? * Store vm on the upper level * Fix kotlin lint errors * Disable ktlint github action because it conflicts too much with local ktlint and it also ignores yml config file, so, it is not possible to ignore some lint errors * Remove android linter step completely
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Report #67