Strict mode for concurrency - Swift 6 support #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for the Phone tab previews coordinator
kyzmitch
commented
Aug 13, 2024
catowseriOS/CoreBrowser/History/InMemoryDomainSearchProvider.swift
Outdated
Show resolved
Hide resolved
…yzmitch/Cotton into feature/more_canonical_tabs_repository # Conflicts: # catowseriOS/CoreBrowser/UseCases/LazyServiceLocator.swift # catowseriOS/CoreBrowser/UseCases/UseCaseLocator.swift
…k with Swift 6 projects yet
|
Decided to merge this PR sooner without waiting for GitHub actions support of Xcode 16, because 2nd open PR #80 doesn't compile in Xcode 16 as well even without settings Swift 6.0 and also I'm expecting to see some merge conflicts and 2nd PR can't be used for development for now because of that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xcode project now uses Swift 6.0 so after merge Xcode 15.4 can't be used anymore, need to use Xcode 16.0 beta
Changes:
Sendablemarkers)Tabtype withCoreBrowser.Tabbecause iOS 18 beta now provides systemSwiftUI.Tabtypepreconcurrencyfor the older 3rd party dependencies which may not support full concurrency yet@preconcurrency. See https://github.com/swiftlang/swift-evolution/blob/main/proposals/0337-support-incremental-migration-to-concurrency-checking.md helps you silence concurrency-related warnings without implementing Sendable conformance@unchecked SendableStateHolderfor internal useCI won't work for this branch yet, because most likely GitHub actions do not use Beta version of Xcode!