Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data service evolution #87

Merged
merged 48 commits into from
Dec 13, 2024
Merged

Data service evolution #87

merged 48 commits into from
Dec 13, 2024

Conversation

kyzmitch
Copy link
Owner

@kyzmitch kyzmitch commented Nov 20, 2024

Should contain work about:

  • evolution of generic data service set of classes/types
  • one more data service in addition to TabsDataService, it will be SearchDataService

Changes:

  • fix TODO about search bar view model (added write use case and inject it, also move view model to factory)
  • use interface of a data service instead of actual implementation
  • base interfaces and class for a data service
  • base class based generic service
  • SearchDataService
  • TabsDataService improvements based on ServiceData (potentially could be reverted)
  • move data services to a separate new module CottonDataServices (also need to consider to use Business Logic based modules where all data services, use cases & view models e.g. related to Search Domain layer are in one module)
  • move use cases to a separate new module CottonUseCases
  • move view models to a separate new module CottonViewModels

Additional minor changes:

  • rename BrowserContentCoordinators to ContentCoordinatorsInterface
  • rename TabsServiceDataOutput to TabsServiceData to be similar to generic service data types
  • rename FeaturesFlagsKit to FeatureFlagsKit

After changes bugs:

@kyzmitch kyzmitch added enhancement todo todo from source code iOS iOS client sources labels Nov 20, 2024
@kyzmitch kyzmitch changed the title Experimental data services Data service evolution Nov 20, 2024
@kyzmitch kyzmitch marked this pull request as ready for review December 13, 2024 15:08
@kyzmitch kyzmitch merged commit 83307f2 into develop Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement iOS iOS client sources todo todo from source code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant