added possibility to dump object space to file before kill for memory limit #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this would be really helpful for us at GitLab to diagnose Ruby leaks. Could we consider updating this branch to be mergable? |
|
Looks like the only conflict is in the README.md. @kzk Can we consider this for a release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the parameter
object_space_dumpto Unicorn::WorkerKiller::Oom. When it is set to true, before killing a process for memory reason, memory object space is dumped to file. By default the file name is/tmp/unicorn_worker_$PID.jsonand can be changed inUnicorn::WorkerKiller::Configurationclass. Dump file is generated throughObjectSpace.dump_allthat is available from Ruby 2.1, so this option can be enabled only with this version of Ruby.