Enable manual requests of restarting in a clean manner #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icorn::WorkerKiller::DelayedRestart.restart_worker_in_a_delayed_manner!+
|
@kzk would love to hear you thoughts about this. |
|
@boazadato how has this been working for you? Curious if you've been using this in production with good results. |
|
@stereoscott yeap its running production for a cpl of months, doing as expected. |
|
@kzk any updates on this ? can this be merged ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable manual requests of restarting in a clean manner by calling
Unicorn::WorkerKiller::DelayedRestart.restart_worker_in_a_delayed_manner!Example: Useful for rack-timeout handling where we want to catch & report the timeout (as recommended by heroku) and still restart the worker out of the request context and avoid H13 errors.