Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatible with unicorn versions after 6.1.0 #80

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

olleolleolle
Copy link

@olleolleolle olleolleolle commented Jul 5, 2024

This PR adapts the call to unicorn by splatting the arguments and passing them on.

The change in arity happened in this commit: k0kubun/unicorn@b652fa5

This PR is compatible with 6.1.0 and with (as yet unreleased) later versions.

I tried with the fork at https://github.com/k0kubun/unicorn/tree/ruby-3-4 - and then I started this.

To try it:

gem "unicorn", github: "k0kubun/unicorn", branch: "ruby-3-4" # See https://github.com/k0kubun/unicorn/tree/ruby-3-4
gem "unicorn-worker-killer", github: "olleolleolle/unicorn-worker-killer", branch: "compatible-with-next"

See #79

@olleolleolle olleolleolle changed the title Try to be compatible with version after 6.1.0 Compatible with versions after 6.1.0 Jul 15, 2024
@olleolleolle olleolleolle marked this pull request as ready for review July 15, 2024 13:31
@olleolleolle olleolleolle changed the title Compatible with versions after 6.1.0 Compatible with unicorn versions after 6.1.0 Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant