This repository has been archived by the owner on Jul 15, 2024. It is now read-only.
Add ability to hide and reveal contracts #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mateuszradomski
suggested changes
Feb 8, 2024
There was a problem hiding this comment.
This is really nice, but I don't like that hidden: boolean field. We can just create an array called hiddenNodes and move nodes from the main array into that array. If a node is present in hiddenNodes it's hidden and we don't need to draw it. This simplifies many things. i.e. reveling all nodes is just
nodes = nodes.concat(...hiddenNodes)
hiddenNodes = []
mateuszradomski
approved these changes
Feb 9, 2024
sdlyy
force-pushed
the
feat/hide-contracts
branch
from
58993c2 to
db1761a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves L2B-2933
Notes