Add support for non-default CUDA streams. #73
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't have enough CUDA experience to review this. @nickjbrowning, could you give this PR a look? |
|
Hello! Many thanks for the contribution I think it's a great idea. We are currently working on separating out the CUDA implementation from the PyTorch front-end, so it becomes possible to use the CUDA implementation as a backend for the Jax front-end as well. I think it's probably best to merge this PR into this new CUDA branch, so I can fix the conflicts there. We'll get on this ASAP. |
|
Closing this PR, as we're resolving this here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Sphericart only supports tensors / operations on the default stream. These changes allow it to work with inputs on any CUDA stream.