Skip to content

Commit

Permalink
KBP-175 #time 3h add usefull pronto runners
Browse files Browse the repository at this point in the history
  • Loading branch information
İsmail Akbudak committed Jan 3, 2018
1 parent bc8dd3b commit 2daa208
Show file tree
Hide file tree
Showing 7 changed files with 46 additions and 3 deletions.
4 changes: 4 additions & 0 deletions cybele.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ Gem::Specification.new do |spec|
spec.add_development_dependency 'pronto', '~> 0.9.5'
spec.add_development_dependency 'pronto-flay', '~> 0.9.0'
spec.add_development_dependency 'pronto-rubocop', '~> 0.9.0'
spec.add_development_dependency 'pronto-fasterer', '~> 0.9.0'
spec.add_development_dependency 'pronto-reek', '~> 0.9.0'
spec.add_development_dependency 'pronto-poper', '~> 0.9.0'
spec.add_development_dependency 'pronto-spell', '~> 0.9.0'
spec.add_development_dependency 'rspec', '~> 3.5'
spec.add_development_dependency 'thor', '~> 0.19.4'

Expand Down
6 changes: 6 additions & 0 deletions lib/cybele/helpers/pronto.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,12 @@ def configure_pronto
template 'pronto/example.pronto.yml.erb',
'.pronto.yml',
force: true
template 'pronto/.haml-lint.yml.erb',
'.haml-lint.yml',
force: true
template 'pronto/config.reek.erb',
'config.reek',
force: true
template 'pronto/.rubocop.yml.erb',
'.rubocop.yml',
force: true
Expand Down
2 changes: 1 addition & 1 deletion spec/support/paperclip_test_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
module PaperclipTestHelper
def paperclip_test
gemfile_file = content('Gemfile')
expect(gemfile_file).to match(/^gem "paperclip"/)
expect(gemfile_file).to match(/^gem 'paperclip'/)
expect(gemfile_file).to match(/^gem 'aws-sdk'/)

env_sample_file_test
Expand Down
11 changes: 11 additions & 0 deletions spec/support/pronto_test_helpers.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,24 @@ def pronto_test
def file_exist_test
gemfile_file = content('Gemfile')
expect(gemfile_file).to match("gem 'pronto'")
expect(gemfile_file).to match("gem 'pronto-brakeman'")
expect(gemfile_file).to match("gem 'pronto-fasterer'")
expect(gemfile_file).to match("gem 'pronto-flay'")
expect(gemfile_file).to match("gem 'pronto-haml'")
expect(gemfile_file).to match("gem 'pronto-jscs'")
expect(gemfile_file).to match("gem 'pronto-poper'")
expect(gemfile_file).to match("gem 'pronto-rails_best_practices'")
expect(gemfile_file).to match("gem 'pronto-reek'")
expect(gemfile_file).to match("gem 'pronto-rubocop'")
expect(gemfile_file).to match("gem 'pronto-scss'")
expect(gemfile_file).to match("gem 'pronto-spell'")
end

def file_content_test # rubocop:disable Metrics/AbcSize
expect(File).to exist(file_project_path('example.pronto.yml'))
expect(File).to exist(file_project_path('.pronto.yml'))
expect(File).to exist(file_project_path('.haml-lint.yml'))
expect(File).to exist(file_project_path('config.reek'))
expect(File).to exist(file_project_path('.rubocop.yml'))
expect(File).to exist(file_project_path('bin/rubo'))
end
Expand Down
17 changes: 15 additions & 2 deletions templates/Gemfile.erb
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,22 @@ group :development, :test do
gem 'colorize', '~> 0.8.1'
gem 'guard', '~> 2.14', '>= 2.14.1'
gem 'mailtrap', '~> 0.2.1'
end

# Pronto runners
group :development do
gem 'pronto', '~> 0.9.5'
gem 'pronto-flay', '~> 0.9.0', require: false
gem 'pronto-rubocop', '~> 0.9.0', require: false
gem 'pronto-brakeman', require: false
gem 'pronto-fasterer', require: false
gem 'pronto-flay', require: false
gem 'pronto-haml', require: false
gem 'pronto-jscs', require: false
gem 'pronto-poper', require: false
gem 'pronto-rails_best_practices', require: false
gem 'pronto-reek', require: false
gem 'pronto-rubocop', require: false
gem 'pronto-scss', require: false
gem 'pronto-spell', require: false
end

# A set of common locale data and translations to internationalize and/or localize your Rails applications.
Expand Down
3 changes: 3 additions & 0 deletions templates/pronto/.haml-lint.yml.erb
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
linters:
LineLength:
max: 100
6 changes: 6 additions & 0 deletions templates/pronto/config.reek.erb
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
IrresponsibleModule:
enabled: false

"lib/modules":
IrresponsibleModule:
enabled: true

0 comments on commit 2daa208

Please sign in to comment.