Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incrementally numbered waypoints #172

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

icrf2000
Copy link
Contributor

@icrf2000 icrf2000 commented Nov 9, 2018

Should address issue #82.

A new button (type="incwp") which generates incrementally numbered waypoints. The format of the waypoint text is by default "WPT_0000", "WPT_0001"... The user can specify a different format in the button layout XML file if desired.

Hans-Joachim Zimmer added 4 commits November 8, 2018 18:13
…01,...). Default button layout contains a big button for it. Current value is stored as a preference, so user can manually change it via preference menu if desired (e.g. after app re-installation to avoid re-using values from previous installation).
- Preference incremental_waypoint_count: only accept INT
- incremental_waypoint: Set the UUID in DB, was empty and therefore WP could not be edited
…e time resource, so make it available to the user
@xsaco07 xsaco07 self-assigned this Oct 14, 2019
@xsaco07
Copy link
Contributor

xsaco07 commented Oct 21, 2019

Hi! Thanks again for your contribution @icrf2000
This looks fine but the thing is that I'm not very sure whether the feature that is asked in #82 is to add a specific button which each time is pressed the app registers an incremental way-point or is to increment automatically each time any way-point is pressed.

@icrf2000
Copy link
Contributor Author

A good question, actually something only @severinmenard can answer. My interpretation of the issue description was like your option one, a specific button. Means behavior of the existing button types is unchanged and a new one added which creates the incrementally numbered WPT's.

@severinmenard
Copy link

Actually my initial idea was a specific button but an automatic incremental waypoint count makes more sense and moreover will not affect the UI

@icrf2000
Copy link
Contributor Author

My PR creates a new button type "incwp" (in addition to the existing ones like for example "voicerec", "picture", "textnote", "tag" etc.). One can place it on the GUI by customizing default_buttons_layout.xml. In the PR, there is a demo which looks like this:

incremental_waypoint_gui_02

Pressing the button creates waypoints named "WPT_0001", "WPT_0002",... (the prefix "WPT_" is configurable in default_buttons_layout.xml, so you could also name them e.g. "SURVEY_0001", "SURVEY_0002",... if you wanted). The counter is global, so if one starts a new track, the counting continues. There is a preference setting in the menu which allows to reset it to zero (or an arbitrary number).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants