Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Responsiveness Improvements for Track and Waypoint List Layouts #504

Closed
wants to merge 3 commits into from

Conversation

FR3DD221
Copy link

@FR3DD221 FR3DD221 commented Feb 7, 2025

Addressing layout breaks and text scaling issues when users modify system display and text size settings.

Changes

Track List Item Layout

  • Replaced RelativeLayout with more flexible LinearLayout
  • Implemented dynamic text scaling using autoSizeTextType
  • Increased maximum text auto-sizing from 14sp to 20sp
  • Improved text appearance consistency
  • Enhanced vertical spacing and alignment
  • Removed redundant margin and padding attributes

Waypoint List Item Layout

  • Migrated from RelativeLayout to ConstraintLayout
  • Implemented responsive positioning using constraints
  • Removed hard-coded right margins
  • Ensured dynamic text scaling and alignment

Results

How it looks with the display and text on the biggest size

image

How it looks with the display and text on the medium size

image

This is a fix of PR #494

@miltonials
Copy link

Hi @FR3DD221 !👋🏼
I tested your PR, and the new look is nice. I just have one observation: the spacing between the title and the waypoint indicator is smaller after exporting the trace.

Recording.2025-02-08.002657.1.mp4

This fixed the problem @miltonials mentioned
@FR3DD221
Copy link
Author

Thanks for you feedback, i just commited the fix.

I adjust the id orientation of each track from vertical to horizontal
@jamescr jamescr added this to the 2024.12 --> 2025.02 milestone Feb 13, 2025
@Andyporras
Copy link

When you want to see the waypoints it closes in android 15.
as shown in this video.

Screen_recording_20250213_123634.mp4

@Andyporras
Copy link

also this other bug happens in android 15

Screen_recording_20250213_123953.mp4

@@ -1,14 +1,54 @@
<?xml version="1.0" encoding="utf-8"?>
<androidx.constraintlayout.widget.ConstraintLayout

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This layout is managed as RelativeLayout in the class WaypointListAdapter.java

This is generating the following error wen the user opens the Waypoint List activity:

image

@FR3DD221 FR3DD221 closed this Feb 13, 2025
@FR3DD221 FR3DD221 deleted the fix-pr#494 branch February 13, 2025 20:43
@miltonials
Copy link

Continued on #513

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants