Filter non ASCII character #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanMainguy
force-pushed
the
filter_non_ascii_char
branch
from
425a785 to
fbe6132
Compare
jpjarnoux
approved these changes
Oct 18, 2024
This was referenced Oct 29, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We’ve noticed that many issues in PPanGGOLiN are caused by non-ASCII characters in the
productfield of CDS annotations. This often happens with genomes annotated by Bakta, where some COG annotations include these characters (check out the related Bakta issue here).Problem
The HDF5 tables used by PPanGGOLiN can’t handle non-ASCII characters. When these characters show up in the
productfield, they cause confusing errors and failures in the tool.Implemented Solution
This PR fixes the problem by automatically checking for non-ASCII characters in the
productfield and replacing them with underscores (_). This change will help PPanGGOLiN run smoothly without errors related to non-ASCII characters.Related PPanGGOLiN Issues