Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust logging and fix unwanted progress bar #296

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Adjust logging and fix unwanted progress bar #296

merged 2 commits into from
Oct 29, 2024

Conversation

JeanMainguy
Copy link
Member

This small PR addresses two issues:

  • Changes the log level for missing translation table entries in input genome files from INFO to DEBUG to reduce log clutter when this info is absent across files.
  • Fixed a missing application of the disable_bar flag in the projection step when using the fast flag. This prevent unwanted progress bars from appearing when --disable_prog_bar is enabled.

@JeanMainguy JeanMainguy changed the base branch from dev to add_linter October 29, 2024 14:03
@JeanMainguy JeanMainguy changed the base branch from add_linter to dev October 29, 2024 14:03
@JeanMainguy JeanMainguy marked this pull request as ready for review October 29, 2024 14:15
@axbazin axbazin self-requested a review October 29, 2024 15:26
@axbazin axbazin merged commit 92263af into dev Oct 29, 2024
7 checks passed
@axbazin axbazin deleted the adjust_log_and_bar branch October 29, 2024 15:27
@JeanMainguy JeanMainguy mentioned this pull request Oct 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axbazin axbazin axbazin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JeanMainguy @axbazin