pyproject: use PyYAML 6.0.1 #1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For master, we probably want to set the minimum version to 6.0.1. For stable-23.0, we want to pin to that exact version. |
|
@Bastian-Krause Should I add a PR for stable-23.0 to? |
Much appreciated :) |
With the release of Cython3 the build of PyYAML 5.4.1 is broken [1]. There seems to be no plan to fix 5.4.x branch [2]. Tox tests and a real world example runs fine with 6.0.1 [1] yaml/pyyaml#724 [2] yaml/pyyaml#728 Signed-off-by: Jan Remmet <[email protected]>
Bastian-Krause
force-pushed
the
pyyaml-6.0.1
branch
from
761cbb1
to
24ff7b6
Compare
|
Adjusted the commit message slightly, rebased on current master to see if the tests are happy. |
Bastian-Krause
added
fix
dependencies
Bastian-Krause
approved these changes
Jul 20, 2023
|
@jremmet Why did you close this PR? |
|
@Bastian-Krause Sorry, accidentally cleaned up some branches |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1237 +/- ##
========================================
- Coverage 62.9% 62.9% -0.1%
========================================
Files 159 159
Lines 11751 11756 +5
========================================
- Hits 7399 7397 -2
- Misses 4352 4359 +7 ☔ View full report in Codecov by Sentry. |
Emantor
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the release of Cython3 the build of PyYAML 5.4.1 is broken [1]. There seems to be no plan to fix 5.4.x branch [2]. Tox tests and a real world example runs fine with 6.0.1
[1] yaml/pyyaml#724
[2] yaml/pyyaml#728
fixes #1236
tested also on origin/stable-23.0 with 6.0.1
unit tests are failing because of #1238
Description
Checklist