pyproject.toml: require Sphinx>=2.0.0 for doc feature #1257
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
readthedocs installs Python package dependencies like this:
Until recently
--upgrade-strategy
was specified aseager
, but nowonly-if-needed
[1]. This results in Sphinx 1.8.6 being used.This becomes an issue since Sphinx is not required directly by labgrid, but via sphinx_rtd_theme which loosely requires
sphinx >=1.6,<8
[2]. This results in this readthedocs build error:We could make this work with Sphinx<2.0.0 [3]:
But even with this, another error and several warnings occur:
It's not worth the effort to keep this backwards compatible, so simply require Sphinx>=2.0.0 in labgrid directly.
[1] readthedocs/readthedocs.org#10560
[2] https://github.com/readthedocs/sphinx_rtd_theme/blob/b5833585b25358be94918f13c50530e3e9237e7e/setup.cfg
[3] sphinx-doc/sphinx#5459
Checklist