Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sshdriver: Add Port Forwarding to Unix Sockets #1262

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

zmalinow
Copy link

@zmalinow zmalinow commented Sep 1, 2023

This commit adds a function that will forward a port on the local host to a unix socket on the target.

Description
Adds a function to the ssh driver that allows a unix socket on the target device to be forwarded to a tcp port on the host. This will allow tests to be performed against a running program that has no exposed ports.

Checklist

  • Documentation for the feature
  • Tests for the feature
  • The arguments and description in doc/configuration.rst have been updated
  • Add a section on how to use the feature to doc/usage.rst
  • Add a section on how to use the feature to doc/development.rst
  • PR has been tested
  • Man pages have been regenerated

Emantor
Emantor previously approved these changes Sep 6, 2023
Copy link
Member

@Bastian-Krause Bastian-Krause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise.

tests/test_sshdriver.py Outdated Show resolved Hide resolved
This commit adds a function that will forward a port on the local host
to a unix socket on the target.

Signed-off-by: Zach Malinowski <[email protected]>
@codecov
Copy link

codecov bot commented Sep 17, 2023

Codecov Report

Patch coverage: 90.0% and project coverage change: +0.1% 🎉

Comparison is base (1052d34) 62.9% compared to head (282e230) 63.0%.
Report is 11 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1262     +/-   ##
========================================
+ Coverage    62.9%   63.0%   +0.1%     
========================================
  Files         161     160      -1     
  Lines       11861   11858      -3     
========================================
+ Hits         7470    7482     +12     
+ Misses       4391    4376     -15     
Files Changed Coverage Δ
labgrid/driver/sshdriver.py 57.4% <90.0%> (+1.1%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Emantor Emantor merged commit c4a0833 into labgrid-project:master Sep 18, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants