power: add eth008 power backend #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JensKle
force-pushed
the
eth008_driver
branch
from
b869db7
to
319cc91
Compare
|
CI test errors are not your fault, #1277 fixes them. |
Bastian-Krause
previously approved these changes
Oct 4, 2023
There was a problem hiding this comment.
Looks good to me.
FYI: there is also https://github.com/pdudaemon/pdudaemon, a project that focuses only on PDUs. labgrid's PDUDaemonDriver interfaces with it. So it might be worth a thought to implement this rather over there. Let us know how you think about this.
Note: we should wait for #1277 and rebase this to make CI run this before merging.
Bastian-Krause
added
the
needs rebase
JensKle
force-pushed
the
eth008_driver
branch
from
7756b65
to
44061ba
Compare
Bastian-Krause
removed
the
needs rebase
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1275 +/- ##
========================================
- Coverage 63.0% 62.9% -0.1%
========================================
Files 160 161 +1
Lines 11901 11932 +31
========================================
+ Hits 7502 7510 +8
- Misses 4399 4422 +23 ☔ View full report in Codecov by Sentry. |
use HTTP-GET API defined at https://www.robot-electronics.co.uk/htm/eth008tech.htm Signed-off-by: Jens Kleintje <[email protected]>
Signed-off-by: Jens Kleintje <[email protected]>
JensKle
force-pushed
the
eth008_driver
branch
from
44061ba
to
5a8acba
Compare
Bastian-Krause
changed the title
Bastian-Krause
approved these changes
Nov 28, 2023
Emantor
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a new power driver for robot electronics eth008 using HTTP-GET API.
Locally tested with labgrid-client power on/off/cycle.
Checklist