Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional SEGGER J-Link model IDs to USBDebugger resource #1286

Merged

Conversation

KiBiz
Copy link
Contributor

@KiBiz KiBiz commented Oct 19, 2023

Description
Add additional SEGGER J-Link model ids to the USBDebugger resource. Have been tested on a distributed infrastructure by flashing a Nordic nRF5340 board with built in J-Link using the OpenOCDDriver.

Checklist

  • Documentation for the feature
  • Tests for the feature
  • The arguments and description in doc/configuration.rst have been updated
  • Add a section on how to use the feature to doc/usage.rst
  • Add a section on how to use the feature to doc/development.rst
  • PR has been tested
  • Man pages have been regenerated

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0657977) 63.0% compared to head (8aef832) 63.0%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1286   +/-   ##
======================================
  Coverage    63.0%   63.0%           
======================================
  Files         160     160           
  Lines       11902   11902           
======================================
  Hits         7502    7502           
  Misses       4400    4400           
Files Coverage Δ
labgrid/resource/udev.py 50.4% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bastian-Krause
Copy link
Member

Thank you for contributing. Please add your Signed-off-by.

@KiBiz KiBiz force-pushed the segger-jlink-usbdebugger-ids branch from 773990c to 6b413da Compare October 20, 2023 09:26
@KiBiz
Copy link
Contributor Author

KiBiz commented Oct 20, 2023

Thank you for contributing. Please add your Signed-off-by.

I have added my signed-off-by now. Thanks

…r resource

Signed-off-by: Andreas Martinsson <[email protected]>
[bst: added prefix to commit message]
Signed-off-by: Bastian Krause <[email protected]>
Copy link
Member

@Bastian-Krause Bastian-Krause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a prefix to the commit message.

@Bastian-Krause Bastian-Krause merged commit fe63a1d into labgrid-project:master Oct 20, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants