shelldriver: allow dashes and dots in device names #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aparcar
force-pushed
the
dashes_and_dots
branch
from
0103692
to
3bb5b51
Compare
The `get_ip_addresses` may be called with a specific device and returns alls IP addresses on that interface. Due to a limitation in the regex, devices including either dashes or dots aren't detected. On the OpenWrt distributions the default device is called `br-lan`, usually connecting ethernet ports and WiFi devices. Likewise dots are attached to the device name to specify VLANs. This commit extends the regex to support both dashes and dots. Signed-off-by: Paul Spooren <[email protected]>
aparcar
force-pushed
the
dashes_and_dots
branch
from
3bb5b51
to
6d0b571
Compare
Bastian-Krause
approved these changes
Apr 30, 2024
Emantor
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
get_ip_addressesmay be called with a specific device and returns alls IP addresses on that interface. Due to a limitation in the regex, devices including either dashes or dots aren't detected.On the OpenWrt distributions the default device is called
br-lan, usually connecting ethernet ports and WiFi devices. Likewise dots are attached to the device name to specify VLANs.This commit extends the regex to support both dashes and dots.
Checklist