qemudriver: add support for netdev option in add_port_forward
#1391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case there are more `user` network interfaces defined, allow to specific the netdev. If omitted, an empty string is passed and the behaviour is like before. This is useful for testing OpenWrt inside a QEMU instance, since OpenWrt expects by default a LAN interface on eth0 and a WAN interface (with uplink) on eth1. Previously the port forward would always be added to eth1, which doesn't support SSH due to firewall policies. By adding the netdev to the forward function, the SSHDriver works as expected. Signed-off-by: Paul Spooren <[email protected]>
|
I'm not sure if this feature is to OpenWrt specific |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1391 +/- ##
======================================
Coverage 62.2% 62.2%
======================================
Files 164 164
Lines 12191 12198 +7
======================================
+ Hits 7584 7589 +5
- Misses 4607 4609 +2 ☔ View full report in Codecov by Sentry. |
Emantor
approved these changes
May 6, 2024
jluebbe
requested changes
Jul 17, 2024
| @@ -14,6 +14,10 @@ New Features in 24.0 | |||
| used to pass additional options for the disk directly to QEMU | |||
| - labgrid-client now has a ``write-files`` subcommand to copy files onto mass | |||
| storage devices. | |||
| - The `QEMUDriver` now supports a ``netdev`` argumet which can be added to the | |||
| ``tadd_port_forward`` in case there are more than one network interfaces | |||
There was a problem hiding this comment.
Suggested change
| ``tadd_port_forward`` in case there are more than one network interfaces | |
| ``add_port_forward`` in case there are more than one network interfaces |
|
Looks good otherwise. Please fix the typo, rebase and mark it as "ready for review". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In case there are more
usernetwork interfaces defined, allow to specific the netdev. If omitted, an empty string is passed and the behaviour is like before.This is useful for testing OpenWrt inside a QEMU instance, since OpenWrt expects by default a LAN interface on eth0 and a WAN interface (with uplink) on eth1. Previously the port forward would always be added to eth1, which doesn't support SSH due to firewall policies. By adding the netdev to the forward function, the SSHDriver works as expected.
Checklist