exporter: check ser2net version in exporter #1395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following ser2net versions return nonzero even on a successful use of the -v flag to get the version: v4.4.0 v4.5.0 v4.5.1 v4.6.0 v4.6.1 This was fixed in v4.6.2, which was only recently released. Modify _start() so that it uses subprocess.run() to capture stdout and the returncode, then check against the version and effectively ignore the return value if there's a match. If the ser2net version is one of the unaffected ones (e.g. v4.6.2) and still returns nonzero, then raise an ExporterError. Signed-off-by: Trevor Gamblin <[email protected]>
threexc
force-pushed
the
tgamblin/ser2net_check
branch
from
da8b52a
to
f7a1d38
Compare
|
Force-pushed an update after I realized the comments I added in exporter.py didn't match the commit message. Sorry about that. Feedback would be greatly appreciated in case there's a different way this issue should be addressed. |
Emantor
approved these changes
May 6, 2024
jluebbe
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following ser2net versions return nonzero even on a successful use of the -v flag to get the version:
v4.4.0
v4.5.0
v4.5.1
v4.6.0
v4.6.1
This was fixed in v4.6.2, which was only recently released. Modify _start() so that it uses subprocess.run() to capture stdout and the returncode, then check against the version and effectively ignore the return value if there's a match. If the ser2net version is one of the unaffected ones (e.g. v4.6.2) and still returns nonzero, then raise an ExporterError.
Tested locally by installing in a venv and running the exporter.
Fixes #1383