treewide: fixes to make pylint happier #1423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now the CI fails and that makes me and my PRs unhappy. Signed-off-by: Paul Spooren <[email protected]>
|
@jluebbe I'm puzzled with the network_interface.py stuff but the rest should do the trick. Please give this a minute since all CI jobs are broken right now :( |
The pylint code warns because of a possibly-used-before-assignment, which is only valid in case python gobject introspectiuon is not used. The reason the variable is hidden behind a type check is a hang related to sphinx, which when trying to import the module for autodoc hangs forever. The normal case is that the `nm` variable is always assigned before use, so disable the related warnings. Signed-off-by: Rouven Czerwinski <[email protected]>
|
I pushed a commit on top which disables the warnings inside the agent with the reasoning in the commit message. |
Emantor
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now the CI fails and that makes me and my PRs unhappy.
Checklist
Fixes #1406