util/ssh: stop keepalive in disconnect() when existing connection is used #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…used SSHConnection does not open a new connection if an existing connection is open. It reuses the connection and starts a keepalive command (cat). On disconnect(), the keepalive command is only stopped for newly initiated connections, not for existing ones. Fix that by stopping the keepalive first, unconditionally. Signed-off-by: Bastian Krause <[email protected]>
Bastian-Krause
force-pushed
the
bst/util-ssh-keepalive
branch
from
1eb7785
to
63685d6
Compare
jluebbe
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SSHConnection does not open a new connection if an existing connection is open. It reuses the connection and starts a keepalive command (cat).
On
disconnect(), the keepalive command is only stopped for newly initiated connections, not for existing ones. Fix that.Checklist