examples: fixes, cleanup, use StepLogger instead of StepReporter #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing imports and use correct variable names. Signed-off-by: Bastian Krause <[email protected]>
Signed-off-by: Bastian Krause <[email protected]>
The examples try to demonstrate how labgrid can be used. So use sane, consistent imports for this purpose. Signed-off-by: Bastian Krause <[email protected]>
StepReporter is deprecated, use StepLogger instead. While at it, make use of labgrid's basicConfig(). It provides a very similar format string, so drop all redundant arguments. Also switch from DEBUG to INFO log level for various examples that do not benefit from such a noisy log level. Signed-off-by: Bastian Krause <[email protected]>
Emantor
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The examples are one of the starting points new users might look into. Don't use deprecated classes there and clean up.
Checklist