Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

escape file names passed through ssh #1450

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

escape file names passed through ssh #1450

wants to merge 1 commit into from

Conversation

fhars
Copy link

@fhars fhars commented Jul 25, 2024

Fixes #1392

@Emantor Emantor requested a review from jluebbe August 12, 2024 09:25
jluebbe
jluebbe requested changes Aug 12, 2024
View reviewed changes
Copy link
Member

@jluebbe jluebbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fhars @Emantor Wouldn't this break for local Resources? From a quick look it seems that we should use Resource.wrap_command here: 3a035a8

Emantor added a commit to Emantor/labgrid that referenced this pull request Oct 21, 2024
@Emantor
driver/usbstoragedriver: wrap commands
343abb2 
Use the wrap_command() function to escape command arguments in case a remote
operation over SSH is done.

Fixes labgrid-project#1392
Alternative to labgrid-project#1450

Signed-off-by: Rouven Czerwinski <[email protected]>
@Emantor Emantor mentioned this pull request Oct 21, 2024
Draft
1 task
Emantor added a commit to Emantor/labgrid that referenced this pull request Oct 21, 2024
@Emantor
driver/usbstoragedriver: wrap commands
e3e40b5 
Use the wrap_command() function to escape command arguments in case a remote
operation over SSH is done.

Fixes labgrid-project#1392
Alternative to labgrid-project#1450

Signed-off-by: Rouven Czerwinski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jluebbe jluebbe jluebbe requested changes

@Emantor Emantor Emantor approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

@Emantor Emantor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

write_file does not properly escape file names
3 participants
@fhars @Emantor @jluebbe