Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util/yaml: warn on duplicate keys in mappings #1451

Merged
merged 1 commit into from
Jul 30, 2024
Merged

util/yaml: warn on duplicate keys in mappings #1451

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions labgrid/util/yaml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
This module contains the custom YAML load and dump functions and associated
loader and dumper
"""

import warnings
from collections import OrderedDict, UserString
from string import Template

Expand All @@ -16,7 +18,19 @@ class Dumper(yaml.SafeDumper):
pass


def _check_duplicate_dict_keys(loader, node):
seen_keys = []
for key_node, _ in node.value:
key = loader.construct_scalar(key_node)
if key in seen_keys:
warnings.warn(
f"{loader.name}: previous entry with duplicate YAML dictionary key '{key}' overwritten", UserWarning
)
seen_keys.append(key)


def _dict_constructor(loader, node):
_check_duplicate_dict_keys(loader, node)
return OrderedDict(loader.construct_pairs(node))


Expand Down
Loading