-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USBVideoDriver: add support LogiLink UA0379 #1486
Conversation
Thank you. Using this branch, I don't seem to have auto focus (with or without extra options) and I still can't seem to influence the focus using options such as:
|
The control names have changed in the kernel since torvalds/linux@70fa906, which is included in v5.16. Thanks to @michaelolbrich for finding it. It was accepted here: https://patchwork.linuxtv.org/project/linux-media/patch/[email protected]/ So, to re-enable autofocus, you need to use -c 'focus_automatic_continuous=1'. In a separate PR we'll likely need to detect new/old kernels (via |
I see, thank you. The value range for focus_absolute is larger than I thought. It works for me with fixed focus:
or automatic focus:
|
e8d5b15
to
0c5ac9d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1486 +/- ##
========================================
- Coverage 56.6% 56.6% -0.1%
========================================
Files 168 168
Lines 13033 13037 +4
========================================
Hits 7385 7385
- Misses 5648 5652 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Only one of these can match anyway, so using 'if' is just confusing. Signed-off-by: Jan Luebbe <[email protected]>
Signed-off-by: Jan Luebbe <[email protected]>
0c5ac9d
to
87cc175
Compare
This is pretty similar to the existing JPEG cameras and supports manual focus control.
Also do some minor clean-ups while we are here.