Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USBVideoDriver: add support LogiLink UA0379 #1486

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jluebbe
Copy link
Member

@jluebbe jluebbe commented Aug 26, 2024

This is pretty similar to the existing JPEG cameras and supports manual focus control.

Also do some minor clean-ups while we are here.

@jonrebm
Copy link

jonrebm commented Aug 26, 2024

Thank you.

Using this branch, I don't seem to have auto focus (with or without extra options) and I still can't seem to influence the focus using options such as:

-c 'focus_automatic_continuous=0,focus_absolute=0'
-c 'focus_automatic_continuous=0,focus_absolute=40'
-c 'focus_automatic_continuous=0,focus_absolute=100'
-c 'focus_auto=0,focus_absolute=100'

@jluebbe
Copy link
Member Author

jluebbe commented Aug 27, 2024

The control names have changed in the kernel since torvalds/linux@70fa906, which is included in v5.16. Thanks to @michaelolbrich for finding it.

It was accepted here: https://patchwork.linuxtv.org/project/linux-media/patch/[email protected]/

So, to re-enable autofocus, you need to use -c 'focus_automatic_continuous=1'. In a separate PR we'll likely need to detect new/old kernels (via uname -r?) and select the corresponding control name...

@jonrebm
Copy link

jonrebm commented Sep 4, 2024

I see, thank you. The value range for focus_absolute is larger than I thought. It works for me with fixed focus:

labgrid-client video -c "focus_absolute=300"

or automatic focus:

labgrid-client video -c "focus_automatic_continuous=1"

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 56.6%. Comparing base (71bfcd2) to head (87cc175).

Files with missing lines Patch % Lines
labgrid/driver/usbvideodriver.py 0.0% 13 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1486     +/-   ##
========================================
- Coverage    56.6%   56.6%   -0.1%     
========================================
  Files         168     168             
  Lines       13033   13037      +4     
========================================
  Hits         7385    7385             
- Misses       5648    5652      +4     
Flag Coverage Δ
3.10 56.6% <0.0%> (-0.1%) ⬇️
3.11 56.6% <0.0%> (-0.1%) ⬇️
3.12 56.6% <0.0%> (-0.1%) ⬇️
3.13 56.6% <0.0%> (-0.1%) ⬇️
3.9 56.6% <0.0%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Only one of these can match anyway, so using 'if' is just confusing.

Signed-off-by: Jan Luebbe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants