-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update codecov/codecov-action v3 -> v4 #1508
update codecov/codecov-action v3 -> v4 #1508
Conversation
GitHub emits warnings like: The following actions use a deprecated Node.js version and will be forced to run on node20: codecov/codecov-action@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/ The codecov upload hasn't worked reliably in a while. This should fix it. Signed-off-by: Bastian Krause <[email protected]>
8a2072c
to
b6c9e4e
Compare
Rebased on latest master. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1508 +/- ##
========================================
- Coverage 61.8% 56.8% -5.1%
========================================
Files 166 168 +2
Lines 12305 13000 +695
========================================
- Hits 7605 7384 -221
- Misses 4700 5616 +916 ☔ View full report in Codecov by Sentry. |
Sending SIGTERM to the coordinator/exporter processes results in a "Terminated" message. This typically comes from the shell (or OS) when a process doesn't handle SIGTERM explicitly. The OS kills the process immediately, and this prevents Python from running cleanup tasks, such as saving coverage data or executing other signal handlers. Simply using SIGINT instead does not work reliably. This needs more investigation. Until that's fixed, let's rather live with the coverage drop than having no coverage tracking at all. |
f93b6de
to
b6c9e4e
Compare
Dropped the exporter/coordinator coverage collection fix for now. |
4d8ce28
into
labgrid-project:master
Description
GitHub emits warnings like:
The codecov upload hasn't worked reliably in a while. This should fix it.