Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update codecov/codecov-action v3 -> v4 #1508

Merged

Conversation

Bastian-Krause
Copy link
Member

@Bastian-Krause Bastian-Krause commented Sep 30, 2024

Description

GitHub emits warnings like:

The following actions use a deprecated Node.js version and will be forced to run on node20: codecov/codecov-action@v3. For more info:
https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

The codecov upload hasn't worked reliably in a while. This should fix it.

GitHub emits warnings like:

  The following actions use a deprecated Node.js version and will be
  forced to run on node20: codecov/codecov-action@v3. For more info:
  https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

The codecov upload hasn't worked reliably in a while. This should fix
it.

Signed-off-by: Bastian Krause <[email protected]>
@Bastian-Krause
Copy link
Member Author

Rebased on latest master.

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.8%. Comparing base (5e4ab58) to head (b6c9e4e).
Report is 73 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1508     +/-   ##
========================================
- Coverage    61.8%   56.8%   -5.1%     
========================================
  Files         166     168      +2     
  Lines       12305   13000    +695     
========================================
- Hits         7605    7384    -221     
- Misses       4700    5616    +916     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bastian-Krause Bastian-Krause changed the title github: update codecov/codecov-action v3 -> v4 update codecov/codecov-action v3 -> v4, fix coordinator/exporter coverage collection Oct 14, 2024
@Bastian-Krause Bastian-Krause marked this pull request as draft October 15, 2024 08:19
Emantor
Emantor previously approved these changes Oct 15, 2024
@Bastian-Krause
Copy link
Member Author

Bastian-Krause commented Oct 15, 2024

Sending SIGTERM to the coordinator/exporter processes results in a "Terminated" message. This typically comes from the shell (or OS) when a process doesn't handle SIGTERM explicitly. The OS kills the process immediately, and this prevents Python from running cleanup tasks, such as saving coverage data or executing other signal handlers.

Simply using SIGINT instead does not work reliably. This needs more investigation. Until that's fixed, let's rather live with the coverage drop than having no coverage tracking at all.

@Bastian-Krause Bastian-Krause changed the title update codecov/codecov-action v3 -> v4, fix coordinator/exporter coverage collection update codecov/codecov-action v3 -> v4 Oct 15, 2024
@Bastian-Krause
Copy link
Member Author

Dropped the exporter/coordinator coverage collection fix for now.

@Bastian-Krause Bastian-Krause marked this pull request as ready for review October 15, 2024 09:13
@Bastian-Krause Bastian-Krause merged commit 4d8ce28 into labgrid-project:master Oct 15, 2024
15 of 16 checks passed
@Bastian-Krause Bastian-Krause deleted the bst/codecov-bump branch October 15, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants