-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test/Advertise Python 3.13 Support #1511
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bastian-Krause
force-pushed
the
bst/py3.13
branch
2 times, most recently
from
September 30, 2024 13:37
d75f5e0
to
0d87f02
Compare
Bastian-Krause
force-pushed
the
bst/py3.13
branch
from
October 8, 2024 14:02
0d87f02
to
935f459
Compare
Waits for actions/python-versions#312 Edit: merged, PR is ready. |
Bastian-Krause
force-pushed
the
bst/py3.13
branch
from
October 10, 2024 10:07
935f459
to
0ac96e1
Compare
Bastian-Krause
force-pushed
the
bst/py3.13
branch
from
October 14, 2024 09:35
0ac96e1
to
e136f2d
Compare
Rebased on latest master. |
Emantor
previously approved these changes
Oct 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1511 +/- ##
======================================
Coverage 56.6% 56.6%
======================================
Files 168 168
Lines 13033 13033
======================================
Hits 7385 7385
Misses 5648 5648 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Bastian Krause <[email protected]>
Signed-off-by: Bastian Krause <[email protected]>
The extra test summary shows additional information such as why a test was skipped. This is helpful to compare test runs on different Python versions and git states. Signed-off-by: Bastian Krause <[email protected]>
On Python 3.13, the vxi11 module import fails: autodoc: failed to import module 'siglent' from module 'labgrid.driver.power'; the following exception was raised: No module named 'xdrlib' It uses xdrlib which was dropped from Python's standard library with Python 3.13. See labgrid-project#1507 for more details. For the time being, mock the vxi11 module to make the doc builds work on Python 3.13. Signed-off-by: Bastian Krause <[email protected]>
Emantor
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add tests for Python 3.13 (expected on 2024-10-07) and advertise support.
Note that the siglent power backend is incompatible with Python 3.13, see #1509. I think this shouldn't stop us from testing/advertising support, right?
Checklist