driver/rawnetworkinterfacedriver: add interface up/down/(basic, EEE, pause) configuration #1525
+200
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jluebbe
reviewed
Oct 18, 2024
Bastian-Krause
force-pushed
the
bst/rawnet-conf
branch
from
0af4480
to
ec5da80
Compare
Bastian-Krause
force-pushed
the
bst/rawnet-conf
branch
from
ec5da80
to
32b599c
Compare
Add methods to the RawNetworkInterfaceDriver to set interfaces up and down, as well as getting and waiting for the interface state. This allows the driver to take more control over the interface, preconfiguration is not needed anymore. Tests that expect the exporter interface to be down (such as ethernet selftests, cable tests) are now possible. Note that the RawNetworkInterfaceDriver now brings the bound interface up on activate and down on deactivate. Signed-off-by: Bastian Krause <[email protected]>
Add interface configuration (`ethtool --change`) support to the RawNetworkInterfaceDriver. This allows configuring the bound interface (speed, lanes, duplex, port, master-slave, mdix, autoneg, advertise, phyad, xcvr, wol, sopass, msglvl). Also add add a `get_settings()` method to query those settings. Note that ethtool gained the required --json support for the default sub command in v6.10. Signed-off-by: Bastian Krause <[email protected]>
Add interface Energy Efficient Ethernet (EEE) configuration (`ethtool --set-eee`) support to the RawNetworkInterfaceDriver. This allows configuring the EEE parameters eee, tx-lpi, tx-timer and advertise on the bound interface. Also add a `get_eee_settings()` method to query those settings. Note that ethtool gained the required --json support for this sub command in v6.10. Signed-off-by: Bastian Krause <[email protected]>
Add interface pause configuration (`ethtool --pause`) support to the RawNetworkInterfaceDriver. This allows configuring the pause parameters autoneg, rx and tx on the bound interface. Also add a `get_pause_settings()` method to query those settings. Signed-off-by: Bastian Krause <[email protected]>
Bastian-Krause
force-pushed
the
bst/rawnet-conf
branch
from
32b599c
to
a93f147
Compare
|
Rebased on latest master. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1525 +/- ##
========================================
- Coverage 56.6% 56.5% -0.1%
========================================
Files 168 168
Lines 13033 13111 +78
========================================
+ Hits 7385 7417 +32
- Misses 5648 5694 +46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jluebbe
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add methods to the RawNetworkInterfaceDriver to set interfaces up and down, as well as getting and waiting for the interface state. Also add basic/EEE/pause interface configuration and query support.
This allows the driver to take more control over the interface, preconfiguration is not needed anymore. Tests that expect the exporter interface to be down (such as ethernet selftests, cable tests) are now possible.
Note that the RawNetworkInterfaceDriver now brings the bound interface up on activate and down on deactivate.
Also note that ethtool gained the required
--jsonsupport for the default sub command and for--show-eeeonly in v6.10.Checklist